add a designated CBA_Extended_EventHandlers base class#294
Merged
Killswitch00 merged 1 commit intomasterfrom Mar 6, 2016
Merged
add a designated CBA_Extended_EventHandlers base class#294Killswitch00 merged 1 commit intomasterfrom
Killswitch00 merged 1 commit intomasterfrom
Conversation
Killswitch00
added a commit
that referenced
this pull request
Mar 6, 2016
add a designated CBA_Extended_EventHandlers base class
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an issue @bux encountered when trying to reenable XEH on some static / building objects.
Usually those have XEH disabled, which is done by clearing the
CBA_Extended_EventHandlers.When setting up inheritance of the
EventHandlersclass, you actually carry over the references to all sub classes defined in that class.SignAd_Sponsor'sEventHandlersis fromThing.Thinghas an emptyCBA_Extended_EventHandlersclass to disable XEH on random map objects.But bux was trying to inherit the actual root class which is also called
CBA_Extended_EventHandlersand since Arma can only reference base classes by their name, the empty one fromThingwas selected instead of the full one on root config.The only work around currently is to discard the
EventHandlersclass, which is not ideal.This can be avoided by adding a differently named base class.
CBA_Extended_EventHandlers_base.CBA_Extended_EventHandlershas to stay for backwards compatibility...