Handle nil/non-bool returns for keyHandlers#329
Merged
Killswitch00 merged 2 commits intomasterfrom May 15, 2016
Merged
Conversation
Contributor
|
If a |
Contributor
|
I think it would be better if we replace L:70 Benefits:
|
Contributor
Author
|
@Killswitch00 the logging would work like this:
|
Contributor
|
Yeah, commy2 made good points and I agree with his no-spam suggestion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user added key handler returns bad data, arma throws a generic unhelpful error.
_blockInputis returned at bottom of our function, so if a handler returns bad data, our function will return it as well.LOG(won't show under normal debug; we could swap toWARNING(if we want to give feedback (this is what we had before #284)?keyHandlerUp is similar, but doesn't return the results, so it shouldn't matter there.