[FIX]: Add ATSC VCT virtual channel numbers and call signs to XMLTV output#1837
Merged
Merged
Conversation
cfsmp3
approved these changes
Dec 17, 2025
cfsmp3
left a comment
Contributor
There was a problem hiding this comment.
Excellent work! This is a clean, well-implemented enhancement from a proven contributor.
Review Results
- ✅ All Linux builds pass
- ✅ Correct ATSC A/65 bit extraction for major/minor channel numbers
- ✅ Proper UTF-16BE to UTF-8 conversion for VCT short_name
- ✅ Good edge case handling (empty names, whitespace trimming, fallbacks)
- ✅ XML-safe output using
EPG_fprintxml() - ✅ XMLTV DTD compliant (multiple display-name elements)
- ✅ Rust FFI properly updated
- ✅ Changelog updated (including missing entry for #1773)
ATSC A/65 Verification
The bit extraction is correct per Section 6.4:
major_channel_num = ((offset[14] & 0x0F) << 6) | ((offset[15] & 0xFC) >> 2); // ✅
minor_channel_num = ((offset[15] & 0x03) << 8) | offset[16]; // ✅Great follow-up to #1773 - the ATSC XMLTV support is now much more complete!
Approved and merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Description
XMLTV channel definitions now include ATSC VCT-derived virtual channel numbers (major.minor) and call signs, emitted as separate
<display-name>elements and associated with the existing channel ID (program number).Example output:
This follows the XMLTV DTD (display-name+) and the approach discussed in #1835
Note: This PR also adds a changelog entry for the previously merged PR #1773