Fail to get units even if leaf->flags & LYS_SET_UNITS get true

[hxing]

The Yang definition:

    leaf instant {
      type decimal64 {
        fraction-digits 1;
      }
      units celsius;
      description
        "The instantaneous value of the statistic.";
    }

My code like:

if (node->nodetype == LYS_LEAF) {
    const auto *leaf = (const lysc_node_leaf *)node;
    if (leaf->flags & LYS_SET_UNITS) {
        cout << "units is: " << leaflist->units << endl;
    }
}

leaflist->units is always NULL. And (leaf->flags & LYS_SET_UNITS) works.

[michalvasko]

For such a purpose, ignore LYS_SET_UNITS and just look at the units field, it is set if non-NULL. In your code you seem to be mixing leaf and leaflist so maybe that is why it does not work for you.

[hxing]

Thanks a lot for your comments.

Deeper look into this issue, I realized this is not a problem with libyang. By directly parsing the yang and then obtaining the lys_module object, and then checking the node, I can correctly obtain the units attribute.

ly_ctx *ctx = nullptr;
ly_ctx_new(nullptr, 0, &ctx);
lys_module *mod = nullptr;
lys_parse_path(ctx, "some-schema.yang", LYS_IN_YANG, &mod);

const lysc_node *node = nullptr;
node = lys_getnext(node, nullptr, mod->compiled, 0);
LY_LIST_FOR(lysc_node_child(node), node) { print_node(node); }

Previously I installed yang into sysrepo. I used ly_ctx_get_module_implemented to get lysc_module. I can't get units at all.

sr_conn_ctx_t *connection = nullptr;
sr_session_ctx_t *session = nullptr;

sr_context_options(SR_CTX_DEFAULT, 0, nullptr);
sr_connect(0, &connection);
sr_session_start(connection, SR_DS_RUNNING, &session);

auto *ly_ctx = const_cast<struct ly_ctx *>(sr_acquire_context(connection));
const lys_module *module = ly_ctx_get_module_implemented(ly_ctx, "some-schema");

It seems the question is regarding sysrepo.

[michalvasko]

Right, there was a bug that caused units to always be NULL. Please try the latest libyang devel, it should now work.