PMP: Add visitors for polygon_soup_to_polygon_mesh()#4856
Closed
MaelRL wants to merge 7 commits intoCGAL:masterfrom
Closed
PMP: Add visitors for polygon_soup_to_polygon_mesh()#4856MaelRL wants to merge 7 commits intoCGAL:masterfrom
polygon_soup_to_polygon_mesh()#4856MaelRL wants to merge 7 commits intoCGAL:masterfrom
Conversation
polygon_soup_to_polygon_mesh()
Member
Author
|
@lrineau would the current API work for you?
|
lrineau
reviewed
Feb 9, 2021
Member
lrineau
left a comment
There was a problem hiding this comment.
Missing doc
None of the two visitor concepts are documented.
Lightweight copyconstructible visitors?
In the BGL, all the visitors concepts start with:
Refinement of: Copy Constructible (copying a visitor should be a lightweight operation).
The BGL convention is to pass visitor parameters by copy.
It seems the PMP convention is actually non-documented by visitors are passed by non-const references. We should decide what to use and how to document that convention.
Member
Author
|
#5461 reimplemented the main work of this PR, but using named parameters instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds a visitor to two functions so that it easier to keep attributes between points and vertices.
PR status: waiting for feedback on API (from @lrineau) after these new functionalities been used.
TODO:
Release Management
Polygon_mesh_processing