Skip to content

PMP: Add visitors for polygon_soup_to_polygon_mesh()#4856

Closed
MaelRL wants to merge 7 commits intoCGAL:masterfrom
MaelRL:PMP-Add_visitors_to_PS2PM-GF
Closed

PMP: Add visitors for polygon_soup_to_polygon_mesh()#4856
MaelRL wants to merge 7 commits intoCGAL:masterfrom
MaelRL:PMP-Add_visitors_to_PS2PM-GF

Conversation

@MaelRL
Copy link
Copy Markdown
Member

@MaelRL MaelRL commented Jul 20, 2020

Summary of Changes

Adds a visitor to two functions so that it easier to keep attributes between points and vertices.

PR status: waiting for feedback on API (from @lrineau) after these new functionalities been used.

TODO:

  • Double check visitor references
  • Node visitor reference (intersections_impl.h)?
  • Visitor concept
  • small feature

Release Management

  • Affected package(s): Polygon_mesh_processing
  • Feature/Small Feature (if any): TODO
  • Link to compiled documentation (obligatory for small feature) TODO
  • License and copyright ownership: No changes.

@MaelRL MaelRL changed the title Pmp add visitors to ps2 pm gf PMP: Add visitors for polygon_soup_to_polygon_mesh() Jul 20, 2020
@MaelRL MaelRL added this to the 5.2-beta milestone Jul 20, 2020
@MaelRL MaelRL added Small feature Not yet approved The feature or pull-request has not yet been approved. Work in progress labels Jul 20, 2020
@MaelRL
Copy link
Copy Markdown
Member Author

MaelRL commented Jul 20, 2020

@maxGimeno maxGimeno modified the milestones: 5.2-beta, 5.3-beta Oct 16, 2020
Copy link
Copy Markdown
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing doc

None of the two visitor concepts are documented.

Lightweight copyconstructible visitors?

In the BGL, all the visitors concepts start with:

Refinement of: Copy Constructible (copying a visitor should be a lightweight operation).

The BGL convention is to pass visitor parameters by copy.

It seems the PMP convention is actually non-documented by visitors are passed by non-const references. We should decide what to use and how to document that convention.

@sloriot sloriot modified the milestones: 5.3-beta, 5.4-beta Mar 22, 2021
@sloriot sloriot modified the milestones: 5.4-beta, 5.5-beta1 Sep 23, 2021
@MaelRL MaelRL marked this pull request as ready for review December 23, 2021 16:21
@MaelRL MaelRL modified the milestones: 5.5-beta, 5.6-beta Mar 28, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 23, 2023
@MaelRL
Copy link
Copy Markdown
Member Author

MaelRL commented Sep 13, 2023

#5461 reimplemented the main work of this PR, but using named parameters instead.

@MaelRL MaelRL closed this Sep 13, 2023
@MaelRL MaelRL added Replaced and removed Not yet approved The feature or pull-request has not yet been approved. Small feature Work in progress labels Sep 13, 2023
@MaelRL MaelRL modified the milestones: 6.0-beta, Trash / Attic Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants