Skip to content

[Small Feature] Region Growing Revision#5563

Closed
danston wants to merge 162 commits intoCGAL:masterfrom
danston:Region_growing-revision-danston
Closed

[Small Feature] Region Growing Revision#5563
danston wants to merge 162 commits intoCGAL:masterfrom
danston:Region_growing-revision-danston

Conversation

@danston
Copy link
Copy Markdown
Contributor

@danston danston commented Mar 29, 2021

This PR is a revision of the Region_growing component from the Shape_detection package. It includes multiple small and big changes (including a few breaking changes!):

  • added named parameters (that changed the APIs of many class constructors)
  • now the update function from the RegionType concept returns a boolean flag that enables to detect if the input conditions for the new region are satisfied (it is also a breaking change)
  • old fitting classes are now using better versions of the region conditions, more precise and faster, including the correct normal orientations
  • added new classes for getting linear regions in a set of 2D and 3D segments
  • added the Polyline_graph class for extracting a set of polylines from a face graph, which splits this graph into a set of user-defined regions (this is necessary for the decimation algorithm in the PMP)
  • added new classes for getting linear regions on 2D and 3D polylines
  • added several internal functions, which are not yet public, since I am not sure whether we really want to document them
  • extended docs with new examples
  • better and stricter tests for the test suite
  • a few other fixes and internal changes
  • fixed the Polyhedron demo using new API

To be yet done:

The doc files changed:

TODO:

  • shall Polygon_mesh sub-namespace/headers be renamed Triangle_mesh? is not a good name
  • Region growing using planes on mesh is not using a property map (example is not generic at all)
  • Remove Item_to_region_index_map?
  • Replace DOXYGEN_NS by DOXYGEN_RUNNING?
  • Clean and properly document CGAL/Shape_detection/Region_growing/internal/free_functions.h

Release Management

  • Affected package(s): Shape_detection
  • Issue(s) solved (if any): no issues
  • Feature/Small Feature (if any): Small Feature
  • Link to compiled documentation (obligatory for small feature): docs
  • License and copyright ownership: Inria and GF

Tasks:

  • Remove tmp modif in the docs

danston added 25 commits March 19, 2021 11:29
Comment thread BGL/include/CGAL/boost/graph/IO/Generic_facegraph_printer.h Outdated
Comment thread BGL/include/CGAL/boost/graph/parameters_interface.h Outdated
Comment thread Shape_detection/doc/Shape_detection/Shape_detection.txt Outdated
Comment thread Shape_detection/doc/Shape_detection/Shape_detection.txt Outdated
Comment thread Shape_detection/doc/Shape_detection/Shape_detection.txt Outdated
Comment thread Shape_detection/examples/Shape_detection/shape_detection_basic_deprecated.cpp Outdated
@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. and removed Accepted small feature labels Jun 21, 2022
@sloriot sloriot closed this Jun 24, 2022
@sloriot sloriot deleted the Region_growing-revision-danston branch June 24, 2022 12:09
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Jun 24, 2022

Replaced by #6702

@lrineau lrineau removed this from the 5.6-beta milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants