Replace SIGNATURE with mgard::SIGNATURE#195
Conversation
|
@JieyangChen7, just a reminder to take a quick look at this when you have the time. |
7e20c29 to
1f08ba0
Compare
@ben-e-whitney Sorry about the delay. Just got back from vacation. I will review this by the end of this week. |
|
No problem, @JieyangChen7. Hope you had a good vacation. |
|
@ben-e-whitney I tried to build this PR but it gives me this error with enabling CUDA:
|
|
@JieyangChen7 Please try again with the commit I just pushed (b6f5330). On that commit, on Summit, |
|
Thanks, @JieyangChen7. @qliu21, this is ready to be merged. |
This commit replaces the signature macro defined in
include/mgard-x/Metadata.hppwith themgard::SIGNATUREconstant defined ininclude/format.hpp.@JieyangChen7, please review this commit. In addition to the signature switch, it also removes the
Metadata::signaturedata member (since the only valid value ismgard::SIGNATURE). I can keep that member if you prefer.@qliu21, please don't merge this pull request yet. I'll rebase on top of
fix-installation-pathsonce you merge #194.