Update composer.json & travis.yml#138
Merged
Merged
Conversation
added 3 commits
September 4, 2017 14:54
Limited the phpunit version to max 5.7.20 to fix Travis
Composer.json jshint fix
Merge with the patch-2 branch
Collaborator
|
Interesting changes. It looks good for the most part, though I am curious about why the minimum version of PHPUnit is set to 4. Is there something wrong with 3.7, aside from being old? |
Contributor
Author
|
There has to be a cap at phpunit 5.7.* otherwise composer will load phpunit 6 which breaks everything. |
Contributor
Author
|
You can stick with 3.7 if you are that much attached to it. ;-) |
Collaborator
|
Ha, okay. I'll see about getting it merged on Friday if time (and weather) permits. |
Collaborator
|
Merged! Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limited the phpunit version to max 5.7.20 to fix Travis