Skip to content

Release 1.1.1#169

Merged
fosfrancesco merged 49 commits intomainfrom
develop
Nov 4, 2022
Merged

Release 1.1.1#169
fosfrancesco merged 49 commits intomainfrom
develop

Conversation

@manoskary
Copy link
Member

@manoskary manoskary commented Oct 24, 2022

This minor new release addresses minor issues such as:

@manoskary
Copy link
Member Author

manoskary commented Oct 24, 2022

Some things to be done:

Copy link
Member

@CarlosCancino-Chacon CarlosCancino-Chacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok! I will approve the commit after pull requests #167 and #168 are merged.

Declare encoding and add/update docstrings at the top of each module
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 80.59% // Head: 81.17% // Increases project coverage by +0.57% 🎉

Coverage data is based on head (52b47d4) compared to base (d1bee81).
Patch coverage: 92.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   80.59%   81.17%   +0.57%     
==========================================
  Files          63       63              
  Lines       10278    10488     +210     
==========================================
+ Hits         8284     8514     +230     
+ Misses       1994     1974      -20     
Impacted Files Coverage Δ
partitura/directions.py 78.49% <ø> (ø)
partitura/io/importnakamura.py 85.71% <ø> (ø)
partitura/musicanalysis/__init__.py 100.00% <ø> (ø)
partitura/musicanalysis/key_identification.py 84.48% <ø> (ø)
partitura/musicanalysis/pitch_spelling.py 90.56% <ø> (ø)
partitura/musicanalysis/tonal_tension.py 85.38% <ø> (ø)
tests/__init__.py 100.00% <ø> (ø)
tests/test_load_score.py 90.47% <ø> (+0.47%) ⬆️
tests/test_mei.py 99.44% <ø> (+<0.01%) ⬆️
tests/test_metrical_position.py 97.14% <ø> (+0.08%) ⬆️
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@fosfrancesco fosfrancesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok, approved

@manoskary
Copy link
Member Author

The tests Fix is not resolved but I propose merging the PR and moving the issue to the next release. Note to change the ReadTheDocs latest tag to main.

manoskary and others added 2 commits November 4, 2022 17:34
added branch renaming on changes.md
@fosfrancesco fosfrancesco merged commit 730e5a5 into main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants