Conversation
staff is always 1 in MEI import, since only parts with a single staff exist added a test for voices and staves
Added missing symbol for consecutive ties.
This PR addresses a Pitch Class representation of the piano-roll and a random generation of a piano-roll.
This PR addresses some bugs in MEI import.
Support for Matchfile Version 1.0.0
fixes a bug where save_musicxml uses the total number of staves which was recomputed multiple times per measure, restarting a non-optimized loop over all score elements: save_musicxml took minutes to hours even for moderately complex scores.
manoskary
previously approved these changes
Dec 1, 2022
Member
manoskary
left a comment
manoskary
left a comment
There was a problem hiding this comment.
This Release 1.2.0 seems ok, I only have a minor comment about typing.
There are a lot of new tests which is nice. The new match import is here, which has already been tested with ASAP.
CarlosCancino-Chacon
approved these changes
Dec 1, 2022
manoskary
approved these changes
Dec 1, 2022
Member
manoskary
left a comment
manoskary
left a comment
There was a problem hiding this comment.
Minor corrections for solving load_performance bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the changes for version 1.2.0 to main.
New features
Bug fixes