Conversation
…ray_to_part # Conflicts: # partitura/utils/music.py
…note_array_to_part
# Conflicts: # partitura/io/importmidi.py # partitura/utils/music.py # tests/test_note_array.py
# Conflicts: # partitura/io/importmidi.py # partitura/utils/music.py # tests/test_note_array.py
…note_array_to_part � Conflicts: � partitura/utils/music.py � tests/test_note_array.py
… into note_array_to_part
This PR adds some new performance features in the same style as the score features.
change version in setup.py
Note array to part
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 85.00% 85.33% +0.32%
==========================================
Files 72 79 +7
Lines 12653 13561 +908
==========================================
+ Hits 10756 11572 +816
- Misses 1897 1989 +92
☔ View full report in Codecov by Sentry. |
Member
Author
|
Problem in uniformity: Should I change this? |
fosfrancesco
previously approved these changes
Jun 9, 2023
…make it uniform with make_note_features.
fosfrancesco
previously approved these changes
Jun 9, 2023
huispaty
reviewed
Jun 9, 2023
huispaty
previously approved these changes
Jun 9, 2023
huispaty
approved these changes
Jun 9, 2023
huispaty
approved these changes
Jun 9, 2023
fosfrancesco
approved these changes
Jun 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Release 1.3.0 (major)
This PR addresses release 1.3.0, it includes several bug fixes, code cleaning, documentation, and new functionality.
New Features
partitura.musicanalysis.scorify(note_array);New Optional Features
partitura.load_music21(m21_score)partitura.utils.music.tokenize(score_data, tokenizer)Bug Fixes
nonein Match Export #261clip_note_offargument does not work inslice_ppart_by_time. #248partitura.score.merge_partswith elements without explicit staff info #223Other Changes