update note feature extraction for dynamic features#274
Merged
Conversation
This was
linked to
issues
Jun 15, 2023
manoskary
approved these changes
Jun 15, 2023
Member
manoskary
left a comment
manoskary
left a comment
There was a problem hiding this comment.
This PR looks good, it addresses issues about the dynamics ramp constantly increasing. Instead, the new approach informs about the beginning an end boundaries of a dynamics ramp such as crescendo or diminuendo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes constant activation for dynamic score features. e.g. crescendi will no just start at 0, ramp up to 1 and drop back to zero at their end, not stay constant until a constant loudness direction is found.
This PR addresses the ramping behavior in #244 and also the problems mentioned in #272