Skip to content

MatchFile validation#280

Merged
CarlosCancino-Chacon merged 8 commits intodevelopfrom
match_validation
Jun 22, 2023
Merged

MatchFile validation#280
CarlosCancino-Chacon merged 8 commits intodevelopfrom
match_validation

Conversation

@manoskary
Copy link
Member

This PR adds a validation method for match files and allows the deletion of duplicate score or performance note instances.
This addresses also issue #277

@manoskary manoskary added the enhancement New feature or request label Jun 15, 2023
@manoskary manoskary self-assigned this Jun 15, 2023
@manoskary manoskary linked an issue Jun 15, 2023 that may be closed by this pull request
@manoskary
Copy link
Member Author

I am tagging @neosatrapahereje since he is mentioned for a review/double-checking of the method in the linked issue #277

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.01 🎉

Comparison is base (a07bc96) 85.36% compared to head (9f4e2f1) 85.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
+ Coverage    85.36%   85.38%   +0.01%     
===========================================
  Files           79       79              
  Lines        13552    13584      +32     
===========================================
+ Hits         11569    11599      +30     
- Misses        1983     1985       +2     
Impacted Files Coverage Δ
partitura/io/importmatch.py 81.75% <94.11%> (+1.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@CarlosCancino-Chacon CarlosCancino-Chacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good, and while the limitations of the bug fix are explicitly stated in the docstring of the method, there is at least one case that could result in some issues when comparing the resulting Score and Performance from the match file to those from symbolic scores and MIDI performances. As I commented below, we could add a test to check whether the methods for extracting expressive parameters/score features do not break in this case.

…ning), inlcuded test by duplicating line on match file.
@CarlosCancino-Chacon CarlosCancino-Chacon merged commit 118a6dd into develop Jun 22, 2023
@CarlosCancino-Chacon CarlosCancino-Chacon deleted the match_validation branch June 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug on to_matched_score - forcing note order is not working properly.

4 participants