Conversation
…match file import with minor complexity addition.
|
I am tagging @neosatrapahereje since he is mentioned for a review/double-checking of the method in the linked issue #277 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #280 +/- ##
===========================================
+ Coverage 85.36% 85.38% +0.01%
===========================================
Files 79 79
Lines 13552 13584 +32
===========================================
+ Hits 11569 11599 +30
- Misses 1983 1985 +2
☔ View full report in Codecov by Sentry. |
CarlosCancino-Chacon
left a comment
There was a problem hiding this comment.
The implementation looks good, and while the limitations of the bug fix are explicitly stated in the docstring of the method, there is at least one case that could result in some issues when comparing the resulting Score and Performance from the match file to those from symbolic scores and MIDI performances. As I commented below, we could add a test to check whether the methods for extracting expressive parameters/score features do not break in this case.
…ning), inlcuded test by duplicating line on match file.
This PR adds a validation method for match files and allows the deletion of duplicate score or performance note instances.
This addresses also issue #277