bugfix for midi scores with ts only in one track#308
Merged
CarlosCancino-Chacon merged 1 commit intodevelopfrom Sep 20, 2023
Merged
bugfix for midi scores with ts only in one track#308CarlosCancino-Chacon merged 1 commit intodevelopfrom
CarlosCancino-Chacon merged 1 commit intodevelopfrom
Conversation
…rack. Now this ts is shared between all the tracks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
===========================================
+ Coverage 85.13% 85.24% +0.11%
===========================================
Files 80 80
Lines 13663 13678 +15
===========================================
+ Hits 11632 11660 +28
+ Misses 2031 2018 -13
☔ View full report in Codecov by Sentry. |
CarlosCancino-Chacon
approved these changes
Sep 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some midi scores, like the one produced by Musescore, have 2 tracks, one for each hand, but time signatures only in one track. The other track is then assumed to be 4/4 and this is completely scrambling the note positions if this is untrue.
Now, if only one track has time signatures, they are shared across all tracks.
For the (very very uncommon) case where the midi file maker wanted to have different time signatures for each track, we assume they did specify at least one time signature for each track, so this bugfix won't change anything