Merged
Conversation
bug fix for nakamura match file parsing
handle none type doc order
matchfile v1.0.0 voice parsing fix
fix pattern checking
solution without dummies
manoskary
requested changes
Oct 24, 2023
Member
manoskary
left a comment
There was a problem hiding this comment.
This PR addresses the latest minor release. I have some minor recommendations and comments left for correction.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
huispaty
approved these changes
Oct 25, 2023
manoskary
approved these changes
Oct 25, 2023
Member
manoskary
left a comment
There was a problem hiding this comment.
This PR includes minor fixes. Everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
doc_orderfor sorting notes in thematchfile_from_alignmentfunction if it is not present. This propriety is only present in parts from musicxml scores and previously resulted in an exception for other score formats. This solves doc_order requirement in export_match #326MatchSnoteTrailingScoreandMatchSnoteNoPlayedNotewere always marked asMatchSnoteDeletionandMatchHammerBounceNote,MatchTrailingPlayedNote,MatchTrillNotealways ended up asMatchInsertionNote. This solves Trill notes are not parsed as such from match v0 #286Nonein the output.