Skip to content

Export wav using fluidsynth#353

Merged
manoskary merged 9 commits intodevelopfrom
fluidsynth
May 21, 2024
Merged

Export wav using fluidsynth#353
manoskary merged 9 commits intodevelopfrom
fluidsynth

Conversation

@CarlosCancino-Chacon
Copy link
Member

This pull request adds the following functionality:

  • Export a partitura object to an audio file using Fluidsynth.

    • This functionality is available in pretty_midi, where it only works for MIDI files.
    • Such a method is useful for cross-modal tasks (e.g., transcription, audio-to-score alignment, etc.).
    • This implementation allows for the method to work on all partitura note-based objects (Score, Performance, Part, PerformedPart, note arrays), and thus for all formats supported by partitura.
    • Fluidsynth is treated as an optional import. Instead of adding to the repository a default soundfont (as is the case in pretty_midi, which includes a very small one), the default soundfont is set to be downloaded from the MuseScore soundfonts (which are distributed with the MIT license).
  • Fixes a few minor issues in slice_ppart_by_time adding previously missing MIDI messages and fixing the computation of onset and offset times in ticks.

@CarlosCancino-Chacon CarlosCancino-Chacon self-assigned this Mar 28, 2024
@CarlosCancino-Chacon CarlosCancino-Chacon added the enhancement New feature or request label Mar 28, 2024
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very nice addition. This PR adds export wav with fluidsynth. It includes some useful utilities such as downloading a file.

Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, a few comments and questions were already addressed and answered.

@manoskary manoskary merged commit cabfad3 into develop May 21, 2024
@manoskary manoskary mentioned this pull request Jul 16, 2024
@huispaty huispaty deleted the fluidsynth branch February 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants