Skip to content

Small Fixes#255

Merged
CarrotManMatt merged 50 commits into
mainfrom
small-fixes
Jul 16, 2024
Merged

Small Fixes#255
CarrotManMatt merged 50 commits into
mainfrom
small-fixes

Conversation

@CarrotManMatt

@CarrotManMatt CarrotManMatt commented Jul 12, 2024

Copy link
Copy Markdown
Member
  • Updates dependencies
  • Improves selected linting rules
  • Improves class names
  • Improves command names & descriptions
  • Improves custom exception inheritance/abstract-base-class usage
  • Fix references of "the bot" into "TeX-Bot"
  • Ensures all loggers are annotated as Final
  • Improves autocomplete function type annotations
  • Improves formatting of channel & role names (within documentation & response messages)
  • Improves imports & __all__ class & function exports
  • Fixes spelling & grammar mistakes
  • Improves the usage of Final constants and their capitalisation
  • Improves command response messages
  • Improves autocomplete exception handling
  • Temporarily improves settings names (this will be overhauled in Move configuration to tex-bot-deployment.yaml #221)

@CarrotManMatt CarrotManMatt added the dependencies Changes that interact with managing dependencies label Jul 12, 2024
@CarrotManMatt CarrotManMatt self-assigned this Jul 12, 2024
@CarrotManMatt CarrotManMatt added refactor Improvements to the codebase that do not directly affect users deployment Changes to the deployment or CI/CD configuration labels Jul 12, 2024
@CarrotManMatt CarrotManMatt added the documentation Improvements or additions to documentation label Jul 14, 2024
@CarrotManMatt CarrotManMatt marked this pull request as ready for review July 14, 2024 15:10
Comment thread cogs/remind_me.py Outdated
Comment thread cogs/strike.py
Comment thread exceptions/does_not_exist.py
@MattyTheHacker

Copy link
Copy Markdown
Member

Also why are we changing settings names just to change it again in the config commit? surely it's easier to leave it as is for now then make it better with the config pr

@CarrotManMatt

Copy link
Copy Markdown
Member Author

The changed settings are using the names that will be used after the config update. Just thought that some of the changes matched with some of the fixes here. I suppose there's no difference as to whether they get changed here or in the config.

So the formal question: is it an issue enough that you would like me to remove those changes from this PR?

@MattyTheHacker

Copy link
Copy Markdown
Member

If you can gimme a list of the ones that need changing in the prod config and what they need changing to then it can stay in, not that bothered

@CarrotManMatt

Copy link
Copy Markdown
Member Author

Oh sorry. I didn't make that clear. The external side names I left the same for this exact reason. So the deployment config will only need changing once, as soon as #221 is merged. The changes here are just the internal names to adhere to the format rules specified in the comment at the top of this PR.

TL;DR: The deployment environment variables should not need to be changed for this PR.

@MattyTheHacker

Copy link
Copy Markdown
Member

oh sick no problem at all then

@CarrotManMatt CarrotManMatt merged commit 44efeb6 into main Jul 16, 2024
@CarrotManMatt CarrotManMatt deleted the small-fixes branch July 16, 2024 14:09
MattyTheHacker added a commit that referenced this pull request Jul 17, 2024
This reverts commit 44efeb6.
MattyTheHacker added a commit that referenced this pull request Jul 17, 2024
* Revert "Small Fixes (#255)"

This reverts commit 44efeb6.

* undo changes to year channel command
@CarrotManMatt CarrotManMatt restored the small-fixes branch July 17, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Changes that interact with managing dependencies deployment Changes to the deployment or CI/CD configuration documentation Improvements or additions to documentation refactor Improvements to the codebase that do not directly affect users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants