Small Fixes#255
Conversation
… accessors ordering
|
Also why are we changing settings names just to change it again in the config commit? surely it's easier to leave it as is for now then make it better with the config pr |
|
The changed settings are using the names that will be used after the config update. Just thought that some of the changes matched with some of the fixes here. I suppose there's no difference as to whether they get changed here or in the config. So the formal question: is it an issue enough that you would like me to remove those changes from this PR? |
|
If you can gimme a list of the ones that need changing in the prod config and what they need changing to then it can stay in, not that bothered |
|
Oh sorry. I didn't make that clear. The external side names I left the same for this exact reason. So the deployment config will only need changing once, as soon as #221 is merged. The changes here are just the internal names to adhere to the format rules specified in the comment at the top of this PR. TL;DR: The deployment environment variables should not need to be changed for this PR. |
|
oh sick no problem at all then |
This reverts commit 44efeb6.
Final__all__class & function exportsFinalconstants and their capitalisationtex-bot-deployment.yaml#221)