Merged
Conversation
✅ Deploy Preview for hydroprocess ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
devincowan
approved these changes
Jun 5, 2025
Contributor
devincowan
left a comment
devincowan
left a comment
There was a problem hiding this comment.
This looks good!
It resolves some of the reactive UI issues, but not all of them.
https://github.com/user-attachments/assets/c0808a83-c8bd-43eb-9908-8486b88ad993
So as long as the intent was not to fully resolve all of CAM-684,this is great!
Contributor
|
@MSDrao you will have to resolve conflicts and also get an "acceptance" review from someone like Tony |
devincowan
approved these changes
Jun 6, 2025
|
|
||
| layer.bindPopup(content, { | ||
| maxWidth: 400, | ||
| maxWidth: window.innerWidth < 600 ? 260 : 400, // Responsive width |
Contributor
There was a problem hiding this comment.
this won't work if someone resizes their window after loading the app
but that's a pretty low probability, so this seems good
nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.