Skip to content

On reload don't store duplicated keys #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohe merged 4 commits into from
Jun 29, 2018
Merged

On reload don't store duplicated keys #553

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd6fbcf
If a key bundle is reloaded care should be taken to not store keys th…
rohe Jun 28, 2018
8708520
If a key bundle is reloaded care should be taken to not store keys th…
rohe Jun 28, 2018
7f3b96f
Not part of the 0.14.0 release
rohe Jun 28, 2018
5c48955
Moved JWKS definitions out of test_keyio.py
rohe Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
If a key bundle is reloaded care should be taken to not store keys th… 
…at already are in the key bundle. Updated CHANGELOG.md .
  • Loading branch information
@rohe
rohe committed Jun 28, 2018
commit 8708520968c663496693328ec8aea6a2313711b0
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ The format is based on the [KeepAChangeLog] project.
## 0.14.0 [2018-05-15]

### Fixed
- [#553] Made sure a a reload would not lead to duplicated keys in a keybundle.
Copy link
Collaborator

@schlenk schlenk Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in the 0.14.0 section.

Open a new section for still unreleased changes on top.

Copy link
Contributor Author

@rohe rohe Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

- [#534] Fixed a bug in client_secret_basic authentication
- [#503] Fix error on UserInfo endpoint for removed clients
- [#508] JWT now uses verify keys for JWT verification
Expand Down Expand Up @@ -45,6 +46,7 @@ The format is based on the [KeepAChangeLog] project.
[#532]: https://github.com/OpenIDC/pyoidc/pull/532
[#498]: https://github.com/OpenIDC/pyoidc/issues/498
[#534]: https://github.com/OpenIDC/pyoidc/pull/534
[#553]: https://github.com/OpenIDC/pyoidc/pull/553
Copy link
Collaborator

@schlenk schlenk Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above, move to new section preparing for 0.15.0


## 0.13.1 [2018-04-06]

Expand Down