Merged
Conversation
Closed
Collaborator
Author
|
now passing lint tests, this one is ready for review |
Member
|
@shimwell Do you have a feel for how many scripts are using this plugin now that will be broken by this import change? It's not hard to fix, but it's always a shock when you upgrade or reinstall a plugin and its behavior has changed like this. |
Collaborator
Author
|
I've only seen my own scripts which I've fixed in fusion-energy/cad_to_dagmc#128 Not seen any other use. There might be some but I've not seen it. Perhaps we use the rust style versioning to indicate breaking API changes and release v0.2.0 after this PR Also I'm not sure if it actually does break the current way of using it. |
Member
|
Thanks @shimwell ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #14 by adding a file import to the init
examples and tests have been updated to use
instead of