Skip to content

[codex] Fix hero Capacitor label translation text#628

Merged
riderx merged 1 commit into
mainfrom
codex/fix-capacitorjs-hero-text
May 2, 2026
Merged

[codex] Fix hero Capacitor label translation text#628
riderx merged 1 commit into
mainfrom
codex/fix-capacitorjs-hero-text

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 2, 2026

Summary

  • Move the visible <CapacitorJS app/> hero label into CSS generated content so the translation worker no longer treats the escaped angle-bracket text as translatable page copy.
  • Keep an sr-only plain-text fallback for accessibility without the problematic angle brackets.

Validation

  • bunx prettier --write apps/web/src/components/Hero.astro
  • cd apps/web && bun run check

Summary by CodeRabbit

  • Style
    • Updated the Hero component's headline rendering to use CSS-based styling while maintaining the same visual appearance and accessibility standards.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f55268f-c832-4a1b-b593-223c9ddf3583

📥 Commits

Reviewing files that changed from the base of the PR and between 2570ef2 and de635f7.

📒 Files selected for processing (1)
  • apps/web/src/components/Hero.astro

📝 Walkthrough

Walkthrough

The Hero component's decorative <CapacitorJS app/> text has been refactored from inline HTML markup to CSS-generated content via a pseudo-element, with an explicit screen-reader label added for accessibility.

Changes

Hero Component Styling Refactor

Layer / File(s) Summary
Markup Structure
apps/web/src/components/Hero.astro (lines 183–188)
Replaced inline <span class="text-azure-500"> with an empty decorative span (hero-capacitor-target, aria-hidden="true") and added a separate <span class="sr-only">CapacitorJS app</span> for screen readers.
CSS Styling
apps/web/src/components/Hero.astro (lines 360–365)
Added .hero-capacitor-target::before { content: '<CapacitorJS app/>'; } to render the decorative text via CSS pseudo-element.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

A span grew light, no text in sight,
CSS whispers, rendering bright.
::before dances with azure glow,
While sr-only lets readers know. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the hero Capacitor label to address translation issues by moving it from HTML to CSS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-capacitorjs-hero-text

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 2, 2026

@riderx riderx marked this pull request as ready for review May 2, 2026 19:13
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@riderx riderx merged commit 6c44061 into main May 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant