Improve alternate desktop sound playback with shared PCM mixer#11137
Open
Madwand99 wants to merge 3 commits into
Open
Improve alternate desktop sound playback with shared PCM mixer#11137Madwand99 wants to merge 3 commits into
Madwand99 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the desktop “Use Alternate Sound System” path to use a shared PCM mixer instead of opening a new
SourceDataLinefor every sound effect.The previous alternate path avoided JavaSound
Clip, but each effect still created and opened its own audio line. In bursty cases like dealing cards or auto-tapping lands, that caused irregular timing, overlapping artifacts, and poor rhythm. This change keeps the alternate pathClip-free while making playback much closer to the normal sound system.Changes
SourceDataLine.draw.mp3tap.mp3untap.mp3Why
This was motivated by intermittent desktop sound/lockup issues where the normal
Clippath appeared to crash inside the Java/PipeWire audio stack. The alternate sound system avoided that path, but sounded noticeably wrong for repeated effects. A shared mixer avoidsClipand avoids per-effect audio-line setup jitter.Thanks to Codex for help with code!