Skip to content

Added authors model, validation and testing #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ApprenticeofEnder merged 6 commits into from
Jun 2, 2021
Merged

Added authors model, validation and testing #46

ApprenticeofEnder merged 6 commits into from
Jun 2, 2021

Conversation

@ApprenticeofEnder
Copy link
Collaborator

@ApprenticeofEnder ApprenticeofEnder commented May 25, 2021

Resolved #24. Added author model, same as Categories effectively

MathyouMB
MathyouMB approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@MathyouMB MathyouMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before we merge though, could we add Authors to the question serializer? That way will also be closing #26.

@ApprenticeofEnder
Copy link
Collaborator Author

ApprenticeofEnder commented May 26, 2021

LGTM. Before we merge though, could we add Authors to the question serializer? That way will also be closing #26.

Will do!

@ApprenticeofEnder
Copy link
Collaborator Author

ApprenticeofEnder commented Jun 2, 2021

FINALLY.

MathyouMB
MathyouMB approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@MathyouMB MathyouMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ApprenticeofEnder ApprenticeofEnder merged commit 8b27d8c into master Jun 2, 2021
@ApprenticeofEnder ApprenticeofEnder deleted the Authors branch June 2, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MathyouMB MathyouMB MathyouMB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Author Model

3 participants

@ApprenticeofEnder @MathyouMB