Skip to content

306 fix cannot read undefined layer#307

Merged
simon-contreras-deel merged 4 commits intomasterfrom
306-fix-cannot-read-undefined-layer
Jun 24, 2019
Merged

306 fix cannot read undefined layer#307
simon-contreras-deel merged 4 commits intomasterfrom
306-fix-cannot-read-undefined-layer

Conversation

@rafatower
Copy link
Contributor

This does a couple things:

  • it makes sure CartoCSS comments are not taken into account further down the line
  • it does not attempt to apply turbocarto if there's no layer definition

@rafatower
Copy link
Contributor Author

Here's a branch testing the integration with Windshaft: CartoDB/Windshaft#692

Note that that test is "more end-to-end" (static rendering of the torque image) and that it crashes without the updated torque dependency.

Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be ok.

I am not really sure about filtering comments. I have tested cartocss in Windshaft with some lines commented and works fine. But anyway, it is a commented code, it is not making anything, so I don't see any problem filtering it.

@simon-contreras-deel simon-contreras-deel merged commit 63e70d1 into master Jun 24, 2019
@simon-contreras-deel simon-contreras-deel deleted the 306-fix-cannot-read-undefined-layer branch June 24, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants