306 fix cannot read undefined layer#307
Merged
simon-contreras-deel merged 4 commits intomasterfrom Jun 24, 2019
Merged
Conversation
Contributor
Author
|
Here's a branch testing the integration with Windshaft: CartoDB/Windshaft#692 Note that that test is "more end-to-end" (static rendering of the torque image) and that it crashes without the updated torque dependency. |
simon-contreras-deel
approved these changes
Jun 19, 2019
Contributor
simon-contreras-deel
left a comment
There was a problem hiding this comment.
It seems to be ok.
I am not really sure about filtering comments. I have tested cartocss in Windshaft with some lines commented and works fine. But anyway, it is a commented code, it is not making anything, so I don't see any problem filtering it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a couple things: