This repository was archived by the owner on Apr 13, 2020. It is now read-only.
resolve optional arguments for spk pipeline commands#493
Merged
Conversation
yradsmikham
requested review from
bnookala,
edaena,
evanlouie,
mtarng,
samiyaakhtar and
sarath-p
samiyaakhtar
approved these changes
Apr 1, 2020
sarath-p
approved these changes
Apr 1, 2020
bnookala
suggested changes
Apr 1, 2020
mtarng
suggested changes
Apr 1, 2020
Collaborator
mtarng
left a comment
mtarng
left a comment
There was a problem hiding this comment.
We need to update the same logic for spk service install-build-pipeline too: https://github.com/CatalystCode/spk/blob/master/src/commands/service/pipeline.ts#L77-L79
Collaborator
Author
Resolved. |
mtarng
reviewed
Apr 1, 2020
dennisseah
reviewed
Apr 1, 2020
dennisseah
reviewed
Apr 2, 2020
Collaborator
dennisseah
left a comment
dennisseah
left a comment
There was a problem hiding this comment.
a few comments, the rest looks good. thanks
dennisseah
approved these changes
Apr 2, 2020
mtarng
reviewed
Apr 2, 2020
mtarng
approved these changes
Apr 2, 2020
bnookala
approved these changes
Apr 2, 2020
evanlouie
reviewed
Apr 2, 2020
yradsmikham
added a commit
to yradsmikham/spk
that referenced
this pull request
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close microsoft/bedrock#1279.