This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FEATURE] have error code for deployment get command#511
Merged
Conversation
Collaborator
Collaborator
Author
Collaborator
|
@dennisseah yes |
Collaborator
Author
it is also happening for master branch because here https://github.com/CatalystCode/spk/blob/master/src/commands/deployment/get.ts#L244, we have .then and do not have .catch. I will try to fix this. I guess we print warning if we cannot fetch PR, please confirm |
Collaborator
|
@dennisseah interesting, didn't see it happen on master for me but maybe i need to pull again. |
Collaborator
|
@dennisseah i just pulled the latest and it's working on master. Maybe we need to have promise and resolve? |
edaena
approved these changes
Apr 6, 2020
Contributor
edaena
left a comment
There was a problem hiding this comment.
Looks good. Just verify the functionality by running the integration tests before merging.
samiyaakhtar
approved these changes
Apr 6, 2020
Collaborator
samiyaakhtar
left a comment
There was a problem hiding this comment.
Works with -o wide now. Thanks @dennisseah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


ran integration test successfully
closes microsoft/bedrock#1316