Personalized Name String in E-mails#449
Merged
Merged
Conversation
… instead of the generic 'TPEN User' text.
cubap
approved these changes
Feb 18, 2026
Member
cubap
left a comment
There was a problem hiding this comment.
This doesn't address the extra space in the message, but the name fix is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CenterForDigitalHumanities/TPEN-interfaces#459
Summary
sendMail()utility function.claude/configuration files that should not be committedDetails
All emails sent by TPEN Services used a generic "Hello TPEN User" greeting, making them look impersonal and untrustworthy. Both email paths (invitation and removal/departure) already had access to user data at the point of sending but never passed it through.
Changes:
utilities/mailer/index.js— Added optionaluserNameparameter tosendMail()with fallback: passed name → email local part. Added JSDoc.classes/Project/Project.js— Updated bothsendMail()call sites:sendInvite(): resolves name from the user lookup already performed viagetByEmail()removeMember(): resolves name fromuserDataalready fetched viagetSelf()The signature change is backwards-compatible — callers without the 4th argument continue to work with the email local part as the greeting.
Test plan
npm run existsTests— all 66 tests passnpm run unitTests— all non-database tests pass (MongoDB timeouts expected without a running database)