microcontroller: fix reset cmd_id bug - #10
Merged
Merged
Conversation
ianohara
force-pushed
the
ian-reset-bug
branch
from
November 21, 2024 19:40
805aa1e to
441975a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reset command sets the microcontroller-side command id to 0 (see here). This means after a reset, the command progress responses from the micro have ID == 0 regardless of the id we sent.
As it was, we'd send ID=1 for a
reset(), and soresetwould always time out.This fixes this by manually forcing the post-send id we're expecting to 0.