Skip to content

external wallet connection for widget#229

Merged
enemycnt merged 6 commits into
mainfrom
feat/widget-external-wallet-connect
Mar 24, 2022
Merged

external wallet connection for widget#229
enemycnt merged 6 commits into
mainfrom
feat/widget-external-wallet-connect

Conversation

@enemycnt

@enemycnt enemycnt commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

Description

Related Issue Or Context

Closes: #212
Closes: #217

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@render

render Bot commented Mar 9, 2022

Copy link
Copy Markdown

@lgtm-com

lgtm-com Bot commented Mar 9, 2022

Copy link
Copy Markdown

This pull request introduces 11 alerts when merging 480ae3f into 3624e45 - view on LGTM.com

new alerts:

  • 10 for Unused variable, import, function or class
  • 1 for Useless conditional

@lgtm-com

lgtm-com Bot commented Mar 14, 2022

Copy link
Copy Markdown

This pull request introduces 9 alerts when merging e0dcf2c into 3624e45 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class

@enemycnt enemycnt marked this pull request as ready for review March 14, 2022 13:42
@enemycnt enemycnt requested a review from wainola March 14, 2022 13:43
@enemycnt enemycnt merged commit 4dcee31 into main Mar 24, 2022
@enemycnt enemycnt deleted the feat/widget-external-wallet-connect branch March 24, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for widget and widget example External wallet connect for widget

2 participants