Skip to content

Replace onobard.js with own connection logic#231

Merged
enemycnt merged 6 commits into
mainfrom
feat/web3-react
Apr 12, 2022
Merged

Replace onobard.js with own connection logic#231
enemycnt merged 6 commits into
mainfrom
feat/web3-react

Conversation

@enemycnt

Copy link
Copy Markdown
Contributor

Description

Related Issue Or Context

Closes: #221

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@render

render Bot commented Mar 30, 2022

Copy link
Copy Markdown

@lgtm-com

lgtm-com Bot commented Mar 30, 2022

Copy link
Copy Markdown

This pull request introduces 22 alerts when merging 6a6260e into 4dcee31 - view on LGTM.com

new alerts:

  • 22 for Unused variable, import, function or class

@enemycnt enemycnt marked this pull request as ready for review March 31, 2022 21:49
@lgtm-com

lgtm-com Bot commented Mar 31, 2022

Copy link
Copy Markdown

This pull request introduces 20 alerts when merging 6e31809 into 4dcee31 - view on LGTM.com

new alerts:

  • 20 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Apr 1, 2022

Copy link
Copy Markdown

This pull request introduces 19 alerts when merging 52672a6 into 4dcee31 - view on LGTM.com

new alerts:

  • 19 for Unused variable, import, function or class

@enemycnt enemycnt requested a review from wainola April 4, 2022 13:54
@lgtm-com

lgtm-com Bot commented Apr 7, 2022

Copy link
Copy Markdown

This pull request introduces 17 alerts when merging de9bcaa into 4dcee31 - view on LGTM.com

new alerts:

  • 17 for Unused variable, import, function or class

@wainola wainola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment

const LocalProvider = ({
children,
externalProvider,
// externalProvider,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get rid of this commented line?

@lgtm-com

lgtm-com Bot commented Apr 8, 2022

Copy link
Copy Markdown

This pull request introduces 17 alerts when merging a2ae4d5 into 4dcee31 - view on LGTM.com

new alerts:

  • 17 for Unused variable, import, function or class

@enemycnt enemycnt merged commit ac33bcb into main Apr 12, 2022
@enemycnt enemycnt deleted the feat/web3-react branch April 12, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace onobard.js with own connection logic

2 participants