Skip to content

Replace NetworkManagerProvider and leave one single provider on App#233

Merged
enemycnt merged 5 commits into
mainfrom
feat/flatten-providers
Apr 26, 2022
Merged

Replace NetworkManagerProvider and leave one single provider on App#233
enemycnt merged 5 commits into
mainfrom
feat/flatten-providers

Conversation

@enemycnt

@enemycnt enemycnt commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

Description

Related Issue Or Context

Closes: #222

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@render

render Bot commented Apr 14, 2022

Copy link
Copy Markdown

@enemycnt enemycnt force-pushed the feat/flatten-providers branch from ab3d94b to 4541768 Compare April 21, 2022 22:49
@lgtm-com

lgtm-com Bot commented Apr 21, 2022

Copy link
Copy Markdown

This pull request introduces 16 alerts and fixes 6 when merging 4541768 into ac33bcb - view on LGTM.com

new alerts:

  • 16 for Unused variable, import, function or class

fixed alerts:

  • 6 for Unused variable, import, function or class

@enemycnt enemycnt marked this pull request as ready for review April 21, 2022 22:54
@enemycnt enemycnt requested a review from wainola April 21, 2022 22:54
Comment thread packages/core/src/contexts/localWeb3Context/localWeb3Context.tsx Outdated
@lgtm-com

lgtm-com Bot commented Apr 25, 2022

Copy link
Copy Markdown

This pull request introduces 16 alerts and fixes 6 when merging ef7017c into ac33bcb - view on LGTM.com

new alerts:

  • 16 for Unused variable, import, function or class

fixed alerts:

  • 6 for Unused variable, import, function or class

@enemycnt enemycnt merged commit 599f142 into main Apr 26, 2022
@enemycnt enemycnt deleted the feat/flatten-providers branch April 26, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace NetworkManagerProvider and leave one single provider on App

2 participants