Skip to content

SDK integration#249

Merged
wainola merged 11 commits into
mainfrom
feature/use-sdk
Jun 8, 2022
Merged

SDK integration#249
wainola merged 11 commits into
mainfrom
feature/use-sdk

Conversation

@wainola

@wainola wainola commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

Description

Related Issue Or Context

Closes: #234

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from enemycnt June 2, 2022 20:35
@render

render Bot commented Jun 2, 2022

Copy link
Copy Markdown

@lgtm-com

lgtm-com Bot commented Jun 2, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 1 when merging 6ba8945 into 7dab007 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 3, 2022

Copy link
Copy Markdown

This pull request introduces 9 alerts and fixes 1 when merging d88378f into 7dab007 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 3, 2022

Copy link
Copy Markdown

This pull request introduces 9 alerts and fixes 1 when merging 8e96f38 into 7dab007 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@wainola wainola marked this pull request as ready for review June 3, 2022 12:28
@lgtm-com

lgtm-com Bot commented Jun 3, 2022

Copy link
Copy Markdown

This pull request introduces 7 alerts and fixes 1 when merging 637353f into 7dab007 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 6, 2022

Copy link
Copy Markdown

This pull request introduces 7 alerts and fixes 1 when merging 6ba17a4 into 7dab007 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 8, 2022

Copy link
Copy Markdown

This pull request introduces 12 alerts and fixes 1 when merging c84c3d4 into 859a45d - view on LGTM.com

new alerts:

  • 12 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 8, 2022

Copy link
Copy Markdown

This pull request introduces 12 alerts and fixes 1 when merging e075406 into 859a45d - view on LGTM.com

new alerts:

  • 12 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@wainola wainola merged commit ac11bd6 into main Jun 8, 2022
@wainola wainola deleted the feature/use-sdk branch June 8, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace transfer logic with chainbridge SDK

2 participants