Skip to content

AWS SSM support#263

Merged
enemycnt merged 7 commits into
mainfrom
feat/aws-ssm
Jul 8, 2022
Merged

AWS SSM support#263
enemycnt merged 7 commits into
mainfrom
feat/aws-ssm

Conversation

@enemycnt

Copy link
Copy Markdown
Contributor

Description

Related Issue Or Context

Closes: #259

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@render

render Bot commented Jun 30, 2022

Copy link
Copy Markdown

@enemycnt enemycnt requested a review from wainola June 30, 2022 13:29
@lgtm-com

lgtm-com Bot commented Jun 30, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging ad65872 into 470778e - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@wainola wainola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the README to explain how to use this in development and in production?

Comment thread packages/example/public/index.html Outdated
Comment thread packages/example/src/index.tsx Outdated
@lgtm-com

lgtm-com Bot commented Jul 4, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 8fe83a8 into 470778e - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jul 8, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 9643423 into 470778e - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@enemycnt enemycnt merged commit d921099 into main Jul 8, 2022
@enemycnt enemycnt deleted the feat/aws-ssm branch July 8, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSM support

2 participants