Skip to content

SDK events support#267

Merged
wainola merged 4 commits into
mainfrom
feat/sdk-events
Jul 25, 2022
Merged

SDK events support#267
wainola merged 4 commits into
mainfrom
feat/sdk-events

Conversation

@enemycnt

@enemycnt enemycnt commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Description

Related Issue Or Context

Closes: #268

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@render

render Bot commented Jul 19, 2022

Copy link
Copy Markdown

@lgtm-com

lgtm-com Bot commented Jul 19, 2022

Copy link
Copy Markdown

This pull request introduces 17 alerts and fixes 1 when merging 6ec454e into e44be39 - view on LGTM.com

new alerts:

  • 16 for Unused variable, import, function or class
  • 1 for Expression has no effect

fixed alerts:

  • 1 for Unused variable, import, function or class

@enemycnt enemycnt marked this pull request as ready for review July 21, 2022 21:34
@enemycnt enemycnt requested a review from wainola July 21, 2022 21:34
@lgtm-com

lgtm-com Bot commented Jul 21, 2022

Copy link
Copy Markdown

This pull request introduces 12 alerts and fixes 4 when merging e092da0 into 126532e - view on LGTM.com

new alerts:

  • 12 for Unused variable, import, function or class

fixed alerts:

  • 4 for Unused variable, import, function or class

Comment thread packages/core/package.json Outdated
Comment thread packages/core/src/chainbridgeConfig.ts
Comment thread packages/core/src/contexts/Adaptors/EVMAdaptors/handleProposalEvent.ts Outdated
Comment thread packages/core/src/contexts/Adaptors/EVMAdaptors/handleProposalEvent.ts Outdated
Comment thread packages/core/src/contexts/Adaptors/EVMAdaptors/handleProposalEvent.ts Outdated
Comment thread packages/core/src/contexts/Adaptors/EVMAdaptors/makeDeposit.ts Outdated
Comment thread packages/core/src/contexts/Adaptors/EVMAdaptors/useSetBridgeSettingsHook.ts Outdated
Comment thread packages/example/package.json Outdated
Comment thread packages/example/src/components/Fees/index.tsx Outdated
Comment thread packages/example/src/modules/WrapActiveModal/WrapActiveModal.tsx Outdated
@lgtm-com

lgtm-com Bot commented Jul 25, 2022

Copy link
Copy Markdown

This pull request introduces 12 alerts and fixes 4 when merging d059ab5 into 126532e - view on LGTM.com

new alerts:

  • 12 for Unused variable, import, function or class

fixed alerts:

  • 4 for Unused variable, import, function or class

@enemycnt enemycnt requested a review from wainola July 25, 2022 20:00
@lgtm-com

lgtm-com Bot commented Jul 25, 2022

Copy link
Copy Markdown

This pull request introduces 12 alerts and fixes 4 when merging 4dfe876 into 126532e - view on LGTM.com

new alerts:

  • 12 for Unused variable, import, function or class

fixed alerts:

  • 4 for Unused variable, import, function or class

@wainola wainola merged commit 645c3d8 into main Jul 25, 2022
@wainola wainola deleted the feat/sdk-events branch July 25, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new events from SDK

2 participants