Filecoin.ChainNotify

[freezing]

Describe the bug

Filecoin.ChainNotify responses contain payload that escapes JSON. However, this is inconsistent with Lotus, and with a more general expectation that JSON payload of JSON RPC responses is not escaped.

To reproduce

Forest v0.28 example:

wscat -c "ws://forest-node:2345/rpc/v1"
Connected (press CTRL+C to quit)
> {"jsonrpc":"2.0","id":1,"method":"Filecoin.ChainNotify","params":[]}
< {"jsonrpc":"2.0","method":"xrpc.ch.val","params":[5,"[{\"Type\":\"current\",\"Val\":{\"Cids\":[{\"/\":\" ...

Lotus example:

wscat -c "ws://forest-node:2345/rpc/v1"
Connected (press CTRL+C to quit)
> {"jsonrpc":"2.0","id":1,"method":"Filecoin.ChainNotify","params":[]}
< {"jsonrpc":"2.0","method":"xrpc.ch.val","params":[1,[{"Type":"current","Val":{"Cids":[{"/":"bafy

Expected behaviour

I expect JSON RPC responses to not escape JSON, i.e. to be the same as Lotus response.

Environment (please complete the following information):

• OS: Linux
• Branch/commit: v0.28

[freezing]

I think the bug is here:

forest/src/rpc/channel.rs

Line 249 in 344f9d0

let result = serde_json::to_string(result)?;

Should this be serialized using to_value instead of to_string?

[elmattic]

@freezing Thanks for opening the issue! I noticed the same thing, and it's already been fixed in this PR: #5836