fix(rpc test): StateCall and StateReplay#4435
Closed
hanabi1224 wants to merge 2 commits into
Closed
Conversation
aatifsyed
approved these changes
Jun 20, 2024
Member
|
I recommend we don't merge this so that it's clearly visible that the Forest and Lotus output differs at the currently used versions. |
Member
|
@hanabi1224 what do we do with this draft? |
Member
bump |
Contributor
Author
|
Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
For a detailed explanation, see #4432 (comment)
Changes introduced in this pull request:
ReturnTrace::exit_codefieldManually tested with the same snapshot that causes CI failures in https://github.com/ChainSafe/forest/actions/runs/9593268587/job/26453560366#step:5:39
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist