Skip to content

feat(rpc) Implement Filecoin.EthCall#4659

Merged
elmattic merged 7 commits into
mainfrom
elmattic/eth-call
Aug 22, 2024
Merged

feat(rpc) Implement Filecoin.EthCall#4659
elmattic merged 7 commits into
mainfrom
elmattic/eth-call

Conversation

@elmattic

@elmattic elmattic commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

Summary of changes

Changes introduced in this pull request:

  • implement RPC method Filecoin.EthCall
  • API compare test
$ ./forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http --filter EthCall
| RPC Method       | Forest | Lotus |
|------------------|--------|-------|
| Filecoin.EthCall | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4613

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic mentioned this pull request Aug 21, 2024
@elmattic elmattic marked this pull request as ready for review August 22, 2024 10:22
@elmattic elmattic requested a review from a team as a code owner August 22, 2024 10:22
@elmattic elmattic requested review from ruseinov and sudo-shashank and removed request for a team August 22, 2024 10:22
Comment thread src/rpc/methods/eth.rs Outdated
@LesnyRumcajs

Copy link
Copy Markdown
Member

@elmattic can we now improve the error messages in other eth methods? I recall you mentioning that some time ago that this method was a blocker for this.

@elmattic

Copy link
Copy Markdown
Contributor Author

@elmattic can we now improve the error messages in other eth methods? I recall you mentioning that some time ago that this method was a blocker for this.

I'm sorry, but I don't remember. If this rings a bell, I will open an issue.

@LesnyRumcajs

Copy link
Copy Markdown
Member

@elmattic can we now improve the error messages in other eth methods? I recall you mentioning that some time ago that this method was a blocker for this.

I'm sorry, but I don't remember. If this rings a bell, I will open an issue.

It's this, no? #4554

@elmattic

Copy link
Copy Markdown
Contributor Author

@elmattic can we now improve the error messages in other eth methods? I recall you mentioning that some time ago that this method was a blocker for this.

I'm sorry, but I don't remember. If this rings a bell, I will open an issue.

It's this, no? #4554

Indeed!

@elmattic elmattic added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 359a3d1 Aug 22, 2024
@elmattic elmattic deleted the elmattic/eth-call branch August 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EthCall

3 participants