fix: Inaccurate GetSize impl for a few types#7129
Merged
Merged
Codecov / codecov/project
succeeded
Jun 8, 2026 in 1s
64.30% (-0.01%) compared to cdb6e63
View this Pull Request on Codecov
64.30% (-0.01%) compared to cdb6e63
Details
Codecov Report
❌ Patch coverage is 26.50602% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.30%. Comparing base (cdb6e63) to head (f75cf83).
✅ All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/blocks/header.rs | 0.00% | 19 Missing |
| src/state_manager/mod.rs | 0.00% | 10 Missing |
| src/blocks/tipset.rs | 0.00% | 8 Missing |
| src/utils/get_size/mod.rs | 75.86% | 7 Missing |
| src/shim/executor.rs | 0.00% | 5 Missing |
| src/blocks/vrf_proof.rs | 0.00% | 2 Missing |
| src/cid_collections/small_cid_vec.rs | 0.00% | 2 Missing |
| src/rpc/methods/eth.rs | 0.00% | 2 Missing |
| src/shim/econ.rs | 0.00% | 2 Missing |
| src/shim/sector.rs | 0.00% | 2 Missing |
| ... and 1 more |
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/rpc/methods/eth/types.rs | 65.71% <ø> (+1.57%) |
⬆️ |
| src/shim/address.rs | 86.76% <ø> (+1.25%) |
⬆️ |
| src/blocks/vrf_proof.rs | 33.33% <0.00%> (ø) |
|
| src/cid_collections/small_cid_vec.rs | 74.46% <0.00%> (ø) |
|
| src/rpc/methods/eth.rs | 65.40% <0.00%> (+0.14%) |
⬆️ |
| src/shim/econ.rs | 94.07% <0.00%> (ø) |
|
| src/shim/sector.rs | 75.79% <0.00%> (ø) |
|
| src/shim/state_tree.rs | 58.50% <0.00%> (ø) |
|
| src/shim/executor.rs | 85.94% <0.00%> (ø) |
|
| src/utils/get_size/mod.rs | 72.54% <75.86%> (+12.54%) |
⬆️ |
| ... and 3 more |
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update cdb6e63...f75cf83. Read the comment docs.
🚀 New features to boost your workflow:
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Loading