Skip to content

Properly segregate sample scenes by packages  #679

@kantagara

Description

@kantagara

Currently, our sample scenes are kind of intertwined. For example, SampleLogin requires you to import Web3Auth package otherwise it won't work. Our lootbox scene can work OOB so that one is okay.
TODOs

  • Make a separate scene for SampleLogin without web3auth that's bundled with our web3sdk sample and that is using only wallet connect. Since WC t is present in our core solution. So we'd need two scenes. SampleLoginWalletConnect and SampleSceneWeb3AuthAndWalletConnect (this one should go inside the web3auth sample package).
  • SampleMain should stay in the core package sample because it can work with both WC and Web3Auth IIRC
  • Both Lootboxes and Web3Auth samples should be part of the UnitySampleProject
  • SampleInitializer.cs needs to add any scenes that need to be added in EditorBuildSettings
  • Adding additional job that would import samples from web3auth and lootboxes via CI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: MaintenanceAdded to issues and PRs when a change is for repository maintenance , such as CI or linter changes.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions