Summary
Currently we're using a static SignClient instance in WalletConnectCustomProvider to preserve it through termination/logout since disposing of the WalletConnectCore or WalletConnectSignClient causes Unity to quit/exit. This was a known bug among the Wallet Connect team and it has been fixed on the latest version of WalletConnectSharp v2.1.6
Suggested features or ways to address the summary
Remove said static instance and dispose of it during terminate/logout properly.
Motivation
This allows for a cleaner implementation and avoids the WalletConnectCore already initialized error when trying to login more than once.
Acceptance Criteria
- Remove said static instance
- Dispose of said instances during terminate/logout/disconnect.
Blockers
(OPTIONAL) [Do you see any blocker that needs to be done before implementing this feature?]
Additional context
(OPTIONAL) [Add any other context or screenshots/videos about the feature request here.]
Summary
Currently we're using a static
SignClientinstance inWalletConnectCustomProviderto preserve it through termination/logout since disposing of theWalletConnectCoreorWalletConnectSignClientcauses Unity to quit/exit. This was a known bug among the Wallet Connect team and it has been fixed on the latest version ofWalletConnectSharp v2.1.6Suggested features or ways to address the summary
Remove said static instance and dispose of it during terminate/logout properly.
Motivation
This allows for a cleaner implementation and avoids the
WalletConnectCore already initializederror when trying to login more than once.Acceptance Criteria
Blockers
(OPTIONAL) [Do you see any blocker that needs to be done before implementing this feature?]
Additional context
(OPTIONAL) [Add any other context or screenshots/videos about the feature request here.]