-
Notifications
You must be signed in to change notification settings - Fork 245
Further Wallet Provider abstraction #975
Copy link
Copy link
Closed
Labels
Type: EnhancementAdded to issues and PRs when a change includes improvements or optimizations.Added to issues and PRs when a change includes improvements or optimizations.Type: MaintenanceAdded to issues and PRs when a change is for repository maintenance , such as CI or linter changes.Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Metadata
Metadata
Assignees
Labels
Type: EnhancementAdded to issues and PRs when a change includes improvements or optimizations.Added to issues and PRs when a change includes improvements or optimizations.Type: MaintenanceAdded to issues and PRs when a change is for repository maintenance , such as CI or linter changes.Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Summary
We can technically make all RPC provider signers and transaction executors into one.
Suggested features or ways to address the summary
One signer and one transaction executor for all
IwalletProvidersMotivation
This will improved reusability, maintainability and readability in our code base with less parts. More over just like how the previous abstraction allowed every transaction executor to poll txns we can now verify every signature.
Acceptance Criteria
Signing and sending txn works like before
reusability, maintainability and readability increased in the codebase
less parts and signature verification
Blockers
(OPTIONAL) [Do you see any blocker that needs to be done before implementing this feature?]
Dependencies
(OPTIONAL) [Do you know about dependencies that directly affect this issue?]
Additional Context
(OPTIONAL) [Add any other context, files, images (screenshots/videos), diagrams, or documents about the feature request here.]
Final Steps
Type: FeatureType: EnhancementEstimations
| 3 | Mild efort | A day | Low complexity | Low |