Skip to content

Inline docstrings added for WC, NetCore, InProcess signer and txn executor solutions 669#677

Merged
robGG1997 merged 21 commits into
mainfrom
rob/add-inline-docstring-669
Oct 26, 2023
Merged

Inline docstrings added for WC, NetCore, InProcess signer and txn executor solutions 669#677
robGG1997 merged 21 commits into
mainfrom
rob/add-inline-docstring-669

Conversation

@robGG1997
Copy link
Copy Markdown
Contributor

Closes #669

@robGG1997 robGG1997 added this to the 2.5.1 Release milestone Oct 20, 2023
@robGG1997 robGG1997 self-assigned this Oct 20, 2023
@robGG1997 robGG1997 changed the title Inline docstrings added 669 Inline docstrings added for WC, NetCore, InProcess signer and txn executor solutions 669 Oct 20, 2023
Copy link
Copy Markdown
Contributor

@sneakzttv sneakzttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay function info!

Comment thread src/ChainSafe.Gaming.InProcessSigner/InProcessSigner.cs Outdated
Comment thread src/ChainSafe.Gaming.InProcessSigner/InProcessSigner.cs Outdated
Comment thread src/ChainSafe.Gaming.InProcessSigner/InProcessSignerExtensions.cs Outdated
Comment thread src/ChainSafe.Gaming.InProcessTransactionExecutor/InProcessTransactionExecutor.cs Outdated
Comment thread src/ChainSafe.Gaming.WalletConnect/IWalletConnectCustomProvider.cs Outdated
Comment thread src/ChainSafe.Gaming.WalletConnect/Models/ChainModel.cs Outdated
Comment thread src/ChainSafe.Gaming.WalletConnect/Models/TransactionModel.cs Outdated
Comment thread src/ChainSafe.Gaming.WalletConnect/WCLogWriter.cs Outdated
Comment thread src/ChainSafe.Gaming.WalletConnect/WalletConnectConfig.cs Outdated
@robGG1997 robGG1997 requested a review from kalambet October 24, 2023 09:44
Copy link
Copy Markdown
Member

@kalambet kalambet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@robGG1997 robGG1997 enabled auto-merge (squash) October 25, 2023 11:23
@robGG1997 robGG1997 merged commit b9af329 into main Oct 26, 2023
@robGG1997 robGG1997 deleted the rob/add-inline-docstring-669 branch October 26, 2023 11:53
robGG1997 added a commit that referenced this pull request Nov 3, 2023
…cutor solutions 669 (#677)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* Added Docs to Wallet Connect

* Inline docs for NetCore and improved WC inline docs.

* Added Inline docs for NetCore and improved docs.

* Added inline docs for InProcessSigner and improved previously added docs

* Made requested docs changes
rob1997 pushed a commit that referenced this pull request Jan 16, 2025
…cutor solutions 669 (#677)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* Added Docs to Wallet Connect

* Inline docs for NetCore and improved WC inline docs.

* Added Inline docs for NetCore and improved docs.

* Added inline docs for InProcessSigner and improved previously added docs

* Made requested docs changes
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
…cutor solutions 669 (ChainSafe#677)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* Added Docs to Wallet Connect

* Inline docs for NetCore and improved WC inline docs.

* Added Inline docs for NetCore and improved docs.

* Added inline docs for InProcessSigner and improved previously added docs

* Made requested docs changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write Docsstring for InProcessSigner, InProcessTransactionExecutor, NetCore and WalletConnect

4 participants