Refactor, Cleanup and Sample Import Dependency Fixes 699#682
Merged
Conversation
This reverts commit a555894.
…/web3.unity into rob/wallet-connect-424
Closed
sneakzttv
approved these changes
Oct 30, 2023
Contributor
|
@robGG1997 For me the login buttons for web3auth don't seem to work in editor. |
Contributor
Author
works on my end, what's the issue? |
Contributor
Contributor
works for me too, did you run the setup.sh? I needed to run it in this PR at least |
Contributor
Author
seems to be isolated, it works for @juans-chainsafe too |
juans-chainsafe
approved these changes
Oct 30, 2023
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
Looks good! working correctly and is fetching only the supported networks by wallet connect.
Because these wallets only have support for mainnet, I connected to those using eth mainnet, couldn't test stuff that needs balance on the wallet.
The only thing that is failing, is trying to login in WebGL because is not supported yet, do we need to add some clarification to users about this? cc @kalambet
Member
Yes, this is going to be known limitation. We'll add it as a disclaimer into the release notes. |
Contributor
|
Fix for:
In Remote wallet login has been made in this PR |
Contributor
Author
Fixed in latest commit, thanks for the all the help @kantagara |
Contributor
|
LGTM |
kantagara
approved these changes
Oct 31, 2023
robGG1997
added a commit
that referenced
this pull request
Nov 3, 2023
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * wc integration working * signing/transacting implemented * switched QrCoder with ZXing for generating QrCode Images * chain selection working * main thread dispatcher simplified and WalletConnectModal.cs login error fix * updated scripts path and added remove extra dll before moving to package lib * more path updates and refactor to support testing * Auto-duplicate Package Samples * made some lint changes * more lint fixes * even more lint fixes * disconnect and logout implemented * Changes Made + chain selection reverted/fetched from project config + wallet disconnected if application exits mid run + disconnect method for wallet now async * Auto-duplicate Package Samples * sign typed data checkpoint * sign typed data implemented with Wallet Connect * reverted unwanted changes * error fixes - SceneIndexer.cs doesn't double up scenes - WalletConnectUnity.cs error fix on trust wallet * sign typed data successful * Auto-duplicate Package Samples * Requested Changes Made + WebPageWallet refactored into WalletConnectWallet + Small refactors and renames based on requested PR changes * Auto-duplicate Package Samples * fix path on publish-to-unity-package.bat * wallet model refactor * Auto-duplicate Package Samples * More requested changes made + moved WCLogger to src and used ILogWriter to pass logs * Auto-duplicate Package Samples * requested changes, method order * Auto-duplicate Package Samples * lint fix * updated Logout based on requested changes * Auto-duplicate Package Samples * android build fix * Android Wallet Linking Implemented * Auto-duplicate Package Samples * WalletConnectWallet split into WalletConnectSigner, this is a prelude to separation between ISigner and ITransactionExecutor * Auto-duplicate Package Samples * Changes Made + Added IOS implementation + refactored Unity specific implementations except [preserve] + implemented redirect to wallet option for mobile on Login * Auto-duplicate Package Samples * Lint fix * refactored WalletConnectSigner.cs with optimizations and removed comments * Changes Made + WalletConnectTransactionExecutor Implemented + WC transaction Models and Methods implemented + small fixes and refactors to Web3Accessor and Login * Moved/Refactored UnityEngine.dll from ChainSafe.Gaming.WalletConnect.csproj and used link.xml for preserving types * replaced preserved type with namespace * Auto-duplicate Package Samples * Passing transaction tests * requested changes made * Auto-duplicate Package Samples * made more requested changes * Auto-duplicate Package Samples * signTransaction implemented * Auto-duplicate Package Samples * checkpoint: working android save session * remember me implemented for IOS * Auto-duplicate Package Samples * Refactored a new Service IWalletConnectProvider and move connecting and request out if WalletConnectSigner * removed redundant check * Auto-duplicate Package Samples * more edits opening wallet * Desktop redirecting and linking Implemented * lint fix * removed unnecessary/unused field * Auto-duplicate Package Samples * deeplink uri building fix * checkpoint * bash script files fix ## added a directory check * uptdae scripts * remove scripts merge conflicts * checkpoint * Changes Made + updated wallet connect to v2.1.1 for better Pairing topic and session matching + Renames for WalletConnectProvider based on requested changes * checkpoint * samples added and test duplicate GH action * syntax fix * removed with branch from checkout in duplicate_samples.yml * syntax fix attempt 0 * syntax fix attempt 1 * syntax fix attempt 2 * syntax fix attempt 3 * syntax fix attempt 4 * syntax fix attempt 5 * syntax fix attempt 6 * syntax fix attempt 7 * syntax fix attempt 8 * syntax fix attempt 9 * syntax fix attempt 10 * give permission to run bash script * variable path for version implemented * removed path agnostic implementation * path updates * more path updates * more path changes * more path changes * git add path changes * git add path changes * script updated and tested locally * git add path updates * changed GITHUB_WORKSPACE to github.workspace * more git add path updates * more git add path updates, tested locally * more git add path updates, tested locally * echo ls test * more git add path updates * more git add path updates * added github.workspace to path prefixes * echos and path changes * path updates * echos updated * removed echos and adding web3auth samples * small path updates * updated paths * reverted back to old implementation with variable version support and samples duplicate * path issue fix * web3 auth duplication added * check and create directory * polished CI action and removed duplicate-sample.sh * Changes Made - Added Scene Indexer for Web3 Auth and refactored SceneIndexer - Tested Login with Existing Wallet * Updated web3auth values * refactor and cleanup * testing CI refactor into loop * path substitution fix * path substitution fix * added echos for debugging * added echos for debugging * loop path fix * more path changes * more path updates, hopefully last * even more path updates, gotta work now * even more path updates, must work now * changed trigger from on push to on PR to main, it worked * MiscTests logs updated. * updated mint721 test response * Replaced path strings on CI with repository environment variables * commit path update * moved git config and add into duplicate step * moved git email env variable to duplicate step * added branch checkout * git change * to . * path change to git add * moved commit and push into duplicate step and updated git add path * echo ls copied files * more path updates * git add path update * small git add path update * always try commit * var declaration and ls log moved out of loop * logs added * env variable correct reference * more env var ref fix * syntax fix * log env var * changed env. ref to vars. * updated source copy path * Auto-duplicate Packages Samples * Wallet Dropdown in ExistingWalletLogin now only lists wallets available for current platform. * Auto-duplicate Packages Samples * lint fix * fixed missing namespace issue * Auto-duplicate Packages Samples * small nonce and send transaction bug fix * fixed WebGL login issue * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com> Co-authored-by: Peter Kalambet <peter@kalambet.dev>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * wc integration working * signing/transacting implemented * switched QrCoder with ZXing for generating QrCode Images * chain selection working * main thread dispatcher simplified and WalletConnectModal.cs login error fix * updated scripts path and added remove extra dll before moving to package lib * more path updates and refactor to support testing * Auto-duplicate Package Samples * made some lint changes * more lint fixes * even more lint fixes * disconnect and logout implemented * Changes Made + chain selection reverted/fetched from project config + wallet disconnected if application exits mid run + disconnect method for wallet now async * Auto-duplicate Package Samples * sign typed data checkpoint * sign typed data implemented with Wallet Connect * reverted unwanted changes * error fixes - SceneIndexer.cs doesn't double up scenes - WalletConnectUnity.cs error fix on trust wallet * sign typed data successful * Auto-duplicate Package Samples * Requested Changes Made + WebPageWallet refactored into WalletConnectWallet + Small refactors and renames based on requested PR changes * Auto-duplicate Package Samples * fix path on publish-to-unity-package.bat * wallet model refactor * Auto-duplicate Package Samples * More requested changes made + moved WCLogger to src and used ILogWriter to pass logs * Auto-duplicate Package Samples * requested changes, method order * Auto-duplicate Package Samples * lint fix * updated Logout based on requested changes * Auto-duplicate Package Samples * android build fix * Android Wallet Linking Implemented * Auto-duplicate Package Samples * WalletConnectWallet split into WalletConnectSigner, this is a prelude to separation between ISigner and ITransactionExecutor * Auto-duplicate Package Samples * Changes Made + Added IOS implementation + refactored Unity specific implementations except [preserve] + implemented redirect to wallet option for mobile on Login * Auto-duplicate Package Samples * Lint fix * refactored WalletConnectSigner.cs with optimizations and removed comments * Changes Made + WalletConnectTransactionExecutor Implemented + WC transaction Models and Methods implemented + small fixes and refactors to Web3Accessor and Login * Moved/Refactored UnityEngine.dll from ChainSafe.Gaming.WalletConnect.csproj and used link.xml for preserving types * replaced preserved type with namespace * Auto-duplicate Package Samples * Passing transaction tests * requested changes made * Auto-duplicate Package Samples * made more requested changes * Auto-duplicate Package Samples * signTransaction implemented * Auto-duplicate Package Samples * checkpoint: working android save session * remember me implemented for IOS * Auto-duplicate Package Samples * Refactored a new Service IWalletConnectProvider and move connecting and request out if WalletConnectSigner * removed redundant check * Auto-duplicate Package Samples * more edits opening wallet * Desktop redirecting and linking Implemented * lint fix * removed unnecessary/unused field * Auto-duplicate Package Samples * deeplink uri building fix * checkpoint * bash script files fix ## added a directory check * uptdae scripts * remove scripts merge conflicts * checkpoint * Changes Made + updated wallet connect to v2.1.1 for better Pairing topic and session matching + Renames for WalletConnectProvider based on requested changes * checkpoint * samples added and test duplicate GH action * syntax fix * removed with branch from checkout in duplicate_samples.yml * syntax fix attempt 0 * syntax fix attempt 1 * syntax fix attempt 2 * syntax fix attempt 3 * syntax fix attempt 4 * syntax fix attempt 5 * syntax fix attempt 6 * syntax fix attempt 7 * syntax fix attempt 8 * syntax fix attempt 9 * syntax fix attempt 10 * give permission to run bash script * variable path for version implemented * removed path agnostic implementation * path updates * more path updates * more path changes * more path changes * git add path changes * git add path changes * script updated and tested locally * git add path updates * changed GITHUB_WORKSPACE to github.workspace * more git add path updates * more git add path updates, tested locally * more git add path updates, tested locally * echo ls test * more git add path updates * more git add path updates * added github.workspace to path prefixes * echos and path changes * path updates * echos updated * removed echos and adding web3auth samples * small path updates * updated paths * reverted back to old implementation with variable version support and samples duplicate * path issue fix * web3 auth duplication added * check and create directory * polished CI action and removed duplicate-sample.sh * Changes Made - Added Scene Indexer for Web3 Auth and refactored SceneIndexer - Tested Login with Existing Wallet * Updated web3auth values * refactor and cleanup * testing CI refactor into loop * path substitution fix * path substitution fix * added echos for debugging * added echos for debugging * loop path fix * more path changes * more path updates, hopefully last * even more path updates, gotta work now * even more path updates, must work now * changed trigger from on push to on PR to main, it worked * MiscTests logs updated. * updated mint721 test response * Replaced path strings on CI with repository environment variables * commit path update * moved git config and add into duplicate step * moved git email env variable to duplicate step * added branch checkout * git change * to . * path change to git add * moved commit and push into duplicate step and updated git add path * echo ls copied files * more path updates * git add path update * small git add path update * always try commit * var declaration and ls log moved out of loop * logs added * env variable correct reference * more env var ref fix * syntax fix * log env var * changed env. ref to vars. * updated source copy path * Auto-duplicate Packages Samples * Wallet Dropdown in ExistingWalletLogin now only lists wallets available for current platform. * Auto-duplicate Packages Samples * lint fix * fixed missing namespace issue * Auto-duplicate Packages Samples * small nonce and send transaction bug fix * fixed WebGL login issue * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com> Co-authored-by: Peter Kalambet <peter@kalambet.dev>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * wc integration working * signing/transacting implemented * switched QrCoder with ZXing for generating QrCode Images * chain selection working * main thread dispatcher simplified and WalletConnectModal.cs login error fix * updated scripts path and added remove extra dll before moving to package lib * more path updates and refactor to support testing * Auto-duplicate Package Samples * made some lint changes * more lint fixes * even more lint fixes * disconnect and logout implemented * Changes Made + chain selection reverted/fetched from project config + wallet disconnected if application exits mid run + disconnect method for wallet now async * Auto-duplicate Package Samples * sign typed data checkpoint * sign typed data implemented with Wallet Connect * reverted unwanted changes * error fixes - SceneIndexer.cs doesn't double up scenes - WalletConnectUnity.cs error fix on trust wallet * sign typed data successful * Auto-duplicate Package Samples * Requested Changes Made + WebPageWallet refactored into WalletConnectWallet + Small refactors and renames based on requested PR changes * Auto-duplicate Package Samples * fix path on publish-to-unity-package.bat * wallet model refactor * Auto-duplicate Package Samples * More requested changes made + moved WCLogger to src and used ILogWriter to pass logs * Auto-duplicate Package Samples * requested changes, method order * Auto-duplicate Package Samples * lint fix * updated Logout based on requested changes * Auto-duplicate Package Samples * android build fix * Android Wallet Linking Implemented * Auto-duplicate Package Samples * WalletConnectWallet split into WalletConnectSigner, this is a prelude to separation between ISigner and ITransactionExecutor * Auto-duplicate Package Samples * Changes Made + Added IOS implementation + refactored Unity specific implementations except [preserve] + implemented redirect to wallet option for mobile on Login * Auto-duplicate Package Samples * Lint fix * refactored WalletConnectSigner.cs with optimizations and removed comments * Changes Made + WalletConnectTransactionExecutor Implemented + WC transaction Models and Methods implemented + small fixes and refactors to Web3Accessor and Login * Moved/Refactored UnityEngine.dll from ChainSafe.Gaming.WalletConnect.csproj and used link.xml for preserving types * replaced preserved type with namespace * Auto-duplicate Package Samples * Passing transaction tests * requested changes made * Auto-duplicate Package Samples * made more requested changes * Auto-duplicate Package Samples * signTransaction implemented * Auto-duplicate Package Samples * checkpoint: working android save session * remember me implemented for IOS * Auto-duplicate Package Samples * Refactored a new Service IWalletConnectProvider and move connecting and request out if WalletConnectSigner * removed redundant check * Auto-duplicate Package Samples * more edits opening wallet * Desktop redirecting and linking Implemented * lint fix * removed unnecessary/unused field * Auto-duplicate Package Samples * deeplink uri building fix * checkpoint * bash script files fix ## added a directory check * uptdae scripts * remove scripts merge conflicts * checkpoint * Changes Made + updated wallet connect to v2.1.1 for better Pairing topic and session matching + Renames for WalletConnectProvider based on requested changes * checkpoint * samples added and test duplicate GH action * syntax fix * removed with branch from checkout in duplicate_samples.yml * syntax fix attempt 0 * syntax fix attempt 1 * syntax fix attempt 2 * syntax fix attempt 3 * syntax fix attempt 4 * syntax fix attempt 5 * syntax fix attempt 6 * syntax fix attempt 7 * syntax fix attempt 8 * syntax fix attempt 9 * syntax fix attempt 10 * give permission to run bash script * variable path for version implemented * removed path agnostic implementation * path updates * more path updates * more path changes * more path changes * git add path changes * git add path changes * script updated and tested locally * git add path updates * changed GITHUB_WORKSPACE to github.workspace * more git add path updates * more git add path updates, tested locally * more git add path updates, tested locally * echo ls test * more git add path updates * more git add path updates * added github.workspace to path prefixes * echos and path changes * path updates * echos updated * removed echos and adding web3auth samples * small path updates * updated paths * reverted back to old implementation with variable version support and samples duplicate * path issue fix * web3 auth duplication added * check and create directory * polished CI action and removed duplicate-sample.sh * Changes Made - Added Scene Indexer for Web3 Auth and refactored SceneIndexer - Tested Login with Existing Wallet * Updated web3auth values * refactor and cleanup * testing CI refactor into loop * path substitution fix * path substitution fix * added echos for debugging * added echos for debugging * loop path fix * more path changes * more path updates, hopefully last * even more path updates, gotta work now * even more path updates, must work now * changed trigger from on push to on PR to main, it worked * MiscTests logs updated. * updated mint721 test response * Replaced path strings on CI with repository environment variables * commit path update * moved git config and add into duplicate step * moved git email env variable to duplicate step * added branch checkout * git change * to . * path change to git add * moved commit and push into duplicate step and updated git add path * echo ls copied files * more path updates * git add path update * small git add path update * always try commit * var declaration and ls log moved out of loop * logs added * env variable correct reference * more env var ref fix * syntax fix * log env var * changed env. ref to vars. * updated source copy path * Auto-duplicate Packages Samples * Wallet Dropdown in ExistingWalletLogin now only lists wallets available for current platform. * Auto-duplicate Packages Samples * lint fix * fixed missing namespace issue * Auto-duplicate Packages Samples * small nonce and send transaction bug fix * fixed WebGL login issue * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com> Co-authored-by: Peter Kalambet <peter@kalambet.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #642, #641