Skip to content

Lootbox namespace change and error checks#700

Merged
sneakzttv merged 5 commits into
mainfrom
lootbox-namespace-change
Nov 2, 2023
Merged

Lootbox namespace change and error checks#700
sneakzttv merged 5 commits into
mainfrom
lootbox-namespace-change

Conversation

@sneakzttv
Copy link
Copy Markdown
Contributor

@sneakzttv sneakzttv commented Nov 2, 2023

Issue:
We need to start preparing lootboxes for OPM submission, the scope of this task is a namespace change and error checks #660

Updates:

  • Namespace changed from chainlink.lootboxes to lootboxes.chainlink and all occurrences updated.
  • Updated the transition in login.cs so that the lootbox scene may be used with the login scene if the user hasn't got the main scene set as their 2nd scene (we'll need this once the contracts are up on chain) [REVERTED]
  • We still need to swap all the data so it can use the login scene to be connected to and to pull data from testnet/mainnet as opposed to a local chain, will wait for @oleksandrchainsafe regarding this before we submit to OPM.

To Test:
Import the lootbox package and run it in the editor. You don't need to use the login scene currently as the launcher script initializes from a local rpc node. Just update your web3config class variables in web3.unity\src\UnitySampleProject\Assets\Samples\web3.unity SDK Lootboxes\1.0.0\Chainlink Lootbox Sample\Scripts\ChainlinkLootboxSampleLauncher.cs to match your local node config.

Expected Behavior:
No errors on import due to the namespace changes.
If you're testing with a local RPC node, everything should work as intended.

@sneakzttv sneakzttv added this to the 2.5.1 Release milestone Nov 2, 2023
@sneakzttv sneakzttv linked an issue Nov 2, 2023 that may be closed by this pull request
2 tasks
@sneakzttv sneakzttv closed this Nov 2, 2023
@sneakzttv sneakzttv reopened this Nov 2, 2023
@sneakzttv sneakzttv closed this Nov 2, 2023
@sneakzttv sneakzttv reopened this Nov 2, 2023
@sneakzttv sneakzttv closed this Nov 2, 2023
@sneakzttv sneakzttv reopened this Nov 2, 2023
@sneakzttv sneakzttv requested a review from robGG1997 November 2, 2023 11:08
@sneakzttv sneakzttv merged commit 5473983 into main Nov 2, 2023
@sneakzttv sneakzttv deleted the lootbox-namespace-change branch November 2, 2023 11:19
robGG1997 pushed a commit that referenced this pull request Nov 3, 2023
* Lootbox namespace change

* Auto-duplicate Packages Samples

* Update Login.cs

* Auto-duplicate Packages Samples

---------

Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
rob1997 pushed a commit that referenced this pull request Jan 16, 2025
* Lootbox namespace change

* Auto-duplicate Packages Samples

* Update Login.cs

* Auto-duplicate Packages Samples

---------

Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Lootbox namespace change

* Auto-duplicate Packages Samples

* Update Login.cs

* Auto-duplicate Packages Samples

---------

Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare Lootboxes for openUPM package submission

4 participants