IOS build error fix#718
Merged
Merged
Conversation
This reverts commit a555894.
robGG1997
force-pushed
the
rob/ios-build-error-fix-699
branch
from
79dfcfc to
08fd513
Compare
auto-assign
Bot
requested review from
RyRy79261,
oleksandrchainsafe and
sneakzttv
…nSafe/web3.unity into rob/ios-build-error-fix-699
robGG1997
added
the
ready-to-merge
sneakzttv
approved these changes
Nov 15, 2023
juans-chainsafe
approved these changes
Nov 15, 2023
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
Issue is fixed! But is not working the “Redirect to Wallet” it redirects to the wallet but it doesnt prompt to connect to the app
kalambet
reviewed
Nov 15, 2023
17 tasks
robGG1997
added
ready-to-merge
robGG1997
added
ready-to-merge
kalambet
approved these changes
Nov 16, 2023
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * setup for IOS build based WC's feedback * added custom websocket implementation * refactor and cleanup * moved web socket as plugin in packages * fixed ws destroy error * reuse connection builder after a logout * ignore generated data files in sample project * removed some unwanted changes and ignored files * removed editor folder from assets and added docs for connection builder in WalletConnectConfig.cs * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * transfer erc 1155 test now passing * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * setup for IOS build based WC's feedback * added custom websocket implementation * refactor and cleanup * moved web socket as plugin in packages * fixed ws destroy error * reuse connection builder after a logout * ignore generated data files in sample project * removed some unwanted changes and ignored files * removed editor folder from assets and added docs for connection builder in WalletConnectConfig.cs * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * transfer erc 1155 test now passing * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #699
Make sure Strip Engine Code is set to false and Code Stripping is Set to minimal in Player Settings