fix(dsl): support class pointer arguments#50
Merged
Conversation
spiral-ladder
approved these changes
Jul 14, 2026
nazarhussain
approved these changes
Jul 14, 2026
spiral-ladder
pushed a commit
to ChainSafe/lodestar-z
that referenced
this pull request
Jul 19, 2026
## Summary - route every BLST class extraction through zapi typed conversion so N-API type tags are checked before `napi_unwrap` - pin zapi to the merge commit of [ChainSafe/zapi#50](ChainSafe/zapi#50) until the pointer-argument fix is released - add regression coverage for wrong-class values across signature/public-key aggregation and randomized verification paths ## Motivation Raw `Env.unwrap` accepts any wrapped N-API object. Passing a `SecretKey` where a `PublicKey` or `Signature` is expected can therefore reinterpret a smaller native allocation as a larger structure and read beyond its bounds.
1 task
wemeetagain
pushed a commit
that referenced
this pull request
Jul 20, 2026
## Summary Add an explicit `changelog-sections` config to `release-please-config.json` so generated release notes group commits into named sections. Visible sections: Features, Bug Fixes, Performance Improvements, Code Refactoring, Dependencies, Reverts, Miscellaneous Chores, Documentation. Hidden types (`build`, `ci`, `test`, `style`) are marked `hidden: true` so they don't clutter the changelog. ## Motivation With the default release-please changelog config, only `feat` and `fix` map to visible sections; other conventional-commit types (including `refactor`) are hidden. As a result, #53 (`refactor(js): unify env lifecycle refcounting`) was merged but did **not** appear in the open release PR #51, whose changelog only shows the `Bug Fixes` entry for #50. Adding `refactor` → "Code Refactoring" (and the other types above) as visible sections ensures such changes are reflected in future release notes. ## Test plan - [x] JSON validated (`python3 -m json.tool`) - Config takes effect on the next release-please run 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertArgcomptime so*Classparameters reachunwrapCheckedTypeErrorbefore native accessMotivation
convertArgdocuments support for both class values and class pointers, but the pointer branch used a runtimeif. Zig still analyzed the fallback@compileError, so exported functions accepting*Classcould not compile. Consumers working around this with rawnapi_unwrapcan bypass zapi type-tag validation.