Skip to content

Disable support for SSLv2/3#25

Merged
shroffk merged 1 commit into
ChannelFinder:masterfrom
mark0n:disable-support-for-ssl23
Apr 23, 2018
Merged

Disable support for SSLv2/3#25
shroffk merged 1 commit into
ChannelFinder:masterfrom
mark0n:disable-support-for-ssl23

Conversation

@mark0n

@mark0n mark0n commented Apr 20, 2018

Copy link
Copy Markdown
Contributor

This fixes #24.

@mark0n

mark0n commented Apr 20, 2018

Copy link
Copy Markdown
Contributor Author

The failing test doesn't seem to be related to my change.

@shroffk

shroffk commented Apr 20, 2018

Copy link
Copy Markdown
Contributor

yes, that is fine...the error is due to the absence of the .travis file

@shroffk

shroffk commented Apr 20, 2018

Copy link
Copy Markdown
Contributor

were you able to successfully use the client with the channelfinder service.

@mark0n

mark0n commented Apr 21, 2018

Copy link
Copy Markdown
Contributor Author

I wasn't able to test with master due to some unrelated changes which broke it (at least for my environment). But using a slightly older version (cccf67b), I was able to verify that my change works (connects fine, I get the expected result).

@shroffk

shroffk commented Apr 23, 2018

Copy link
Copy Markdown
Contributor

Ok great,
I will merge this then @shengb

@shroffk shroffk merged commit b601061 into ChannelFinder:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable SSLv2/3

2 participants