Issue #11 changes#12
Merged
Merged
Conversation
…urrently focused on IOC disconnections.
…t disconnections.
…indefinitely. Fixed issue where recceiver was ignoring keepalive response and causing a timeout after 30 seconds. Added more cases to commit order tests.
Collaborator
| @@ -48,125 +55,154 @@ def commit(self, TR): | |||
| if _log.isEnabledFor(logging.DEBUG): | |||
| _log.debug("CF_COMMIT %s", TR.infos.items()) | |||
| pvNames = [unicode(rname, "utf-8") for rid, (rname, rtype) in TR.addrec.iteritems()] | |||
Collaborator
There was a problem hiding this comment.
A minor point. The way to go from string to unicode I've usually seen is str.decode('utf-8').
…elfinder service data to a file, same format as cf-store data file print. Added script for creating 1000~ identical iocs using the recsync demo st.cmd.
…og if it becomes negative. Glassfish server errors are now caught as requests.exceptions.HTTPError instead of StandardError. Mock_client now also uses HTTPError. Mock client uses IPV4Address as its source, rather than an arbitrary object. Recast no longer pauses accepting input, also removed re-initiating listening. test_cfstore cleaned up threading and test commits.
…to unit tests. Changed format of IOCID to match possible new system. Updated owner information. Clean service now uses the update method instead of the set methods. Note: This overwrites ownership in some locations.
…d local path in test_mock_iocs and decreased the number of iocs spawned by default. Cleaned up the dictionary logic in the commit method. Added config control to dict_to_file.
… adding active channels for manual tests. Added readme to describe manual test process. Added debug logging for cleaning stages.
… logic with collections.defaultdict.
Collaborator
|
Could you please note the revision with the necessary changes to the update() method in the python channelfinder client? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue 11