Fix for issue #1#2
Closed
izstas wants to merge 2 commits into
Closed
Conversation
Owner
|
Write a test case mod for the server side like you did for the client. Well done on that by the way. |
Owner
|
Could the IConnectionHandler be moved to a more global scope to reduce the number of IConnectionHandler instances? |
Author
|
Something like this, maybe? |
Owner
|
A new handler section would need to be made for login packets. I don't really think it's worth it though. I'm yet to have a usecase and one could just handle the 250 stream themselves. |
Owner
|
Fixed as of 7f42cd9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you suggested, I used
IConnectionHandlerto getNetClientHandler. I agree that this way is much better.By the way, I think server part has similar problem. However, in that case, only
NetLoginHandlerexists before log in, andIServerPacketHandler.handlePacketsignature needsNetServerHandler. So I don't know.