Add redis topic prefixing#8229
Merged
Merged
Conversation
michaelstaib
approved these changes
Aug 27, 2025
Member
|
Sorry for the wait ... but we are finally moving forward on 15.1.9 and this is going in now. |
michaelstaib
added
the
🍒 cherry-pick
michaelstaib
pushed a commit
that referenced
this pull request
Aug 27, 2025
This was referenced Aug 27, 2025
This was referenced Aug 28, 2025
This was referenced Oct 6, 2025
This was referenced Oct 13, 2025
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a common pattern in Redis to use ACLs to restrict access to channels on a per-service basis, these are based on channel name matching. Currently it is not possible to use ACLs with the provided RedisPubSub since the topic prefix is passed into the formatter and hashed.
This PR prepends the prefix into the actual channel name allowing ACLs to be used.
Redis keys are binary safe therefore any string is valid.